rotaryio: Add the ability to set the divisor #5468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
force-pushed
the
encoder-divisor
branch
from
b4b4fa6 to
bc714d9
Compare
dhalbert
requested changes
Oct 16, 2021
All we do on a BAD state transition is avoid counting up or down, but the same is accomplished by using the "0" table value instead.
At present, Adafruit's rotary encoders all move 1 quadrature cycle per detent, so we originally hard-coded division-by-4. However, other encoders exist, including ones without detents, ones with 2 detents per cycle, and others with 4 detents per cycle. The new `divisor` property and constructor argument allows selecting a divisor of 1, 2, or 4; with the default of 4 giving backward compatibility. The property is not supported (yet?) on espressif MCUs; it throws an error if a value other than 4 is set.
jepler
force-pushed
the
encoder-divisor
branch
from
1009c98 to
9eebb3d
Compare
|
Thanks, rebased & re-enabled on those two boards. They're still within 100 bytes of full in the de_DE translation.. |
|
I can confirm that 9eebb3d allows my half-cycle encoder to work properly, one increment per click, with divisor=2 |
dhalbert
approved these changes
Oct 18, 2021
There was a problem hiding this comment.
@evildave666 Thank you for testing! @jepler thank you for solving this!
|
What was the reason for the lack of support for espressif boards? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At present, Adafruit's rotary encoders all move 1 quadrature cycle per detent, so we originally hard-coded division-by-4. However, other encoders exist, including ones without detents, ones with 2 detents per cycle, and others with 4 detents per cycle.
The new
divisorproperty and constructor argument allows selecting a divisor of 1, 2, or 4; with the default of 4 giving backward compatibility.The property is not supported (yet?) on espressif MCUs; it throws an error if a value other than 4 is set.
It doesn't quite fit but it may after #5466 goes in. Or we could turn off rotaryio in a few more places, like adalogger_m0.
Closes: #5431