-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Remove gamepadshift module #5491
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
0a26198
to
6ccd285
Compare
We were going to do this when we started on 8.0.0. We haven't yet made a 7.x branch yet, so we will keep |
@deshipu OK to make this a draft until then? |
Of course, how do I do that? |
Hi @deshipu We are ready to merge this now. |
Everything should be using the keypad module instead. Note: there are several boards that still had gamepadshift enabled. I did not contact their authors to make sure they already switched to keypad in their code and documentation. We should probably wait with merging this for their go ahead.
6ccd285
to
c0152e7
Compare
@dhalbert I'm sorry, I get way more circuitpython-related notifications from github than I am able to read in my free time, so messages like this just fly by me. I rebased it now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi, one rebase/mergish change
Is this imminent? I know two Learn guides that still use it, been on my radar to move them to |
It will be in 8.0.0-alpha.x. It is not a change to 7.3.x, so it will not affect the Learn Guide code until 8.0.0 final is released, which will be some time from now. |
Co-authored-by: Dan Halbert <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Great, thank you!
Everything should be using the keypad module instead.
Note: there are several boards that still had gamepadshift enabled. I
did not contact their authors to make sure they already switched to
keypad in their code and documentation. We should probably wait with
merging this for their go ahead.
[edit by dhalbert]