Skip to content

Remove gamepadshift module #5491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 25, 2022
Merged

Conversation

deshipu
Copy link

@deshipu deshipu commented Oct 21, 2021

Everything should be using the keypad module instead.

Note: there are several boards that still had gamepadshift enabled. I
did not contact their authors to make sure they already switched to
keypad in their code and documentation. We should probably wait with
merging this for their go ahead.

[edit by dhalbert]

@deshipu deshipu force-pushed the remove-gamepadshift branch from 0a26198 to 6ccd285 Compare October 21, 2021 18:57
@dhalbert
Copy link
Collaborator

We were going to do this when we started on 8.0.0. We haven't yet made a 7.x branch yet, so we will keep main compatible for a while. There is no 8.0.0 issue for removing gamepadshift yet, but there should be.

@dhalbert dhalbert added this to the 8.0.0 milestone Oct 21, 2021
@dhalbert
Copy link
Collaborator

@deshipu OK to make this a draft until then?

@deshipu
Copy link
Author

deshipu commented Oct 21, 2021

Of course, how do I do that?

@dhalbert
Copy link
Collaborator

image

@deshipu deshipu marked this pull request as draft October 21, 2021 19:11
@dhalbert dhalbert marked this pull request as ready for review May 20, 2022 21:33
@dhalbert
Copy link
Collaborator

Hi @deshipu We are ready to merge this now. main is now for 8.0.0 development. Do you have time to fix the merge conflicts?

Everything should be using the keypad module instead.

Note: there are several boards that still had gamepadshift enabled. I
did not contact their authors to make sure they already switched to
keypad in their code and documentation. We should probably wait with
merging this for their go ahead.
@deshipu deshipu force-pushed the remove-gamepadshift branch from 6ccd285 to c0152e7 Compare May 24, 2022 22:49
@deshipu
Copy link
Author

deshipu commented May 24, 2022

@dhalbert I'm sorry, I get way more circuitpython-related notifications from github than I am able to read in my free time, so messages like this just fly by me. I rebased it now.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi, one rebase/mergish change

@tekktrik
Copy link
Member

tekktrik commented May 25, 2022

Is this imminent? I know two Learn guides that still use it, been on my radar to move them to keypad ahead of time, so just want to know!

@dhalbert
Copy link
Collaborator

dhalbert commented May 25, 2022

Is this imminent? I know two Learn guides that still use it, been on my radar to move them to keypad ahead of time, so just want to know!

It will be in 8.0.0-alpha.x. It is not a change to 7.3.x, so it will not affect the Learn Guide code until 8.0.0 final is released, which will be some time from now.

@deshipu
Copy link
Author

deshipu commented May 25, 2022

For some reason, I don't have the option to allow changes to pull requests:
Screenshot_2022-05-25_11-37-21

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great, thank you!

@dhalbert dhalbert merged commit 1fb210b into adafruit:main May 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove gamepadshift in 8.0.0
3 participants