oofatfs: Allow fat32 mkfs to be compiled out. optimize rainbowio & enable everywhere #5578
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Saves 508 bytes
.. there are none that aren't skipped now, but it'll change
.. mp_obj_get_float handles the case where the arg is an int already. This saves 12 bytes of code size on trinket_m0.
.. this saves 76 bytes on trinket_m0
|
You'll want to leave FAT32 in for anything that should support SD cards as well. |
|
This does not disable accessing fat32 filesystems. It disables formatting them. If we have a device with built in flash (or, like the raspberry pi / broadcom port, an SD card that might need FAT32) we can enable that with a preprocessor define. |
tannewt
approved these changes
Nov 15, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The only storage you can format in CircuitPython is the built in flash, and we don't ship any devices which are so big that fat32 is required. So, save space by compiling it out by default. Seemed to save 508 bytes on Trinket M0, 512 bytes on Clue.
Testing performed: that
storage.erase_filesystem()on a Clue created a fresh filesystem usable by Linux & CircuitPython.Then I made it possible to test rainbowio and optimized it for size, saving about 88 bytes of flash storage without changing functionality. (this wasn't strictly necessary, as the above change gave us more than enough space back)
Finally, I enabled rainbowio on the few boards that lacked it before.