Bitmaptools bugfixes #5605
Merged
Bitmaptools bugfixes #5605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this allows `readinto` to succeed in the unix port, where the VFS is not FAT
mp_obj_float_get gets the value of an object, which must be exactly a float. mp_obj_get_float gets the float value of an object of various types, including floats & ints.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The main bugfix is one that caused wrong blending when the int
0or1was used as a blend factor.It also fixes a problem that prevented
bitmaptools.readintofrom working in the unix build, and usesmp_get_stream_raisewhich can prevent a problem if the stream doesn't support the needed operations (and potentially raise a better error)It adds some manual "tests". These reproduced the bitmap blending bug but didn't seem to reproduce the dithering bleed bug (#5568). More investigation is needed there.
Closes: #5567