Skip to content

fix mypy requirement at 0.910, for compatibility #5737

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

jepler
Copy link

@jepler jepler commented Dec 17, 2021

This should fix the doc build, which currently fails

ulab/numpy/__init__.pyi:51: error: Cannot assign multiple types to name "_float" without an explicit "Type[...]" annotation
ulab/numpy/__init__.pyi:54: error: Cannot assign multiple types to name "_bool" without an explicit "Type[...]" annotation

since mypy 0.920 was released.

After

or another fix is merged and our submodule ref is updated, we can un-pin mypy. However, as we may not want to change the version of ulab in 7.1.x right now, this workaround may be preferable.

@jepler
Copy link
Author

jepler commented Dec 17, 2021

Looks like we'll want to take #5740 instead.

@jepler jepler closed this Dec 17, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant