Skip to content

Explicitly cast float to mp_int_t - 7.1.x #5748

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 19, 2021
Merged

Explicitly cast float to mp_int_t - 7.1.x #5748

merged 1 commit into from
Dec 19, 2021

Conversation

dhalbert
Copy link
Collaborator

Backport of #5746.

@dunkmann00 @dhalbert
Explicitly cast float to mp_int_t
0ce5265 
Not sure why this is necessary, but it prevents an off-by-one error in
some (rare?) circumstances.
@dhalbert dhalbert requested a review from jepler December 18, 2021 03:44
jepler
jepler approved these changes Dec 19, 2021
View reviewed changes
Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

@jepler jepler merged commit 4eb7807 into adafruit:7.1.x Dec 19, 2021
@dhalbert dhalbert deleted the pixelbuf-packed-int-error-7.1.x branch December 23, 2021 17:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jepler jepler jepler approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhalbert @jepler @dunkmann00