Skip to content

feather esp32s2 tft: fix sharing of main display bus #5846

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 13, 2022
Merged

feather esp32s2 tft: fix sharing of main display bus #5846

merged 1 commit into from
Jan 13, 2022

Conversation

jepler
Copy link

@jepler jepler commented Jan 12, 2022

Closes: #5843

@jerryneedell jerryneedell mentioned this pull request Jan 12, 2022
Closed
@jerryneedell
Copy link
Collaborator

Tested -- fixes #5843 as long as board.SPI() is used
using bus.SPI(...) still results in SCK in use -- I assume that is expected since it is...

@jepler jepler requested a review from jerryneedell January 12, 2022 20:44
jerryneedell
jerryneedell approved these changes Jan 12, 2022
View reviewed changes
Copy link
Collaborator

@jerryneedell jerryneedell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me -- Tested with an rfm9x featherwing using board.SPI()

ladyada
ladyada approved these changes Jan 12, 2022
View reviewed changes
Copy link
Member

@ladyada ladyada left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@dhalbert dhalbert merged commit 59275c7 into adafruit:main Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ladyada ladyada ladyada approved these changes

@jerryneedell jerryneedell jerryneedell approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ESP32S2-TFT SPI conflict with pin 36
4 participants
@jepler @jerryneedell @ladyada @dhalbert