Skip to content

Automatically cancel superseded CI build of PR #5922

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 26, 2022
Merged

Automatically cancel superseded CI build of PR #5922

merged 1 commit into from
Jan 26, 2022

Conversation

microdev1
Copy link
Collaborator

GitHub Actions concurrency feature adds ability to cancel superseded CI builds.
With the current configuration, builds triggered on push to a branch aren't cancelled.

@jepler
Copy link

jepler commented Jan 25, 2022

@microdev1 any idea what's going wrong with the espressif builds in some of these PRs? #5920 is failing in a similar way.

Successfully installed distlib-0.3.4 filelock-3.4.2 platformdirs-2.4.1 six-1.16.0 virtualenv-20.13.0
FileExistsError: [Errno 17] File exists: '/opt/hostedtoolcache/Python/3.10.2/x64/bin/python' -> '/home/runner/work/circuitpython/circuitpython/.idf_tools/python_env/idf4.4_py3.10_env/bin/python'
Traceback (most recent call last):
Creating a new Python environment in /home/runner/work/circuitpython/circuitpython/.idf_tools/python_env/idf4.4_py3.10_env
  File "/home/runner/work/circuitpython/circuitpython/ports/espressif/esp-idf/tools/idf_tools.py", line 1828, in <module>
Installing virtualenv
    main(sys.argv[1:])
  File "/home/runner/work/circuitpython/circuitpython/ports/espressif/esp-idf/tools/idf_tools.py", line 1824, in main
    action_func(args)
  File "/home/runner/work/circuitpython/circuitpython/ports/espressif/esp-idf/tools/idf_tools.py", line 1524, in action_install_python_env
    subprocess.check_call([sys.executable, '-m', 'virtualenv', '--seeder', 'pip', idf_python_env_path],
  File "/opt/hostedtoolcache/Python/3.10.2/x64/lib/python3.10/subprocess.py", line 369, in check_call
    raise CalledProcessError(retcode, cmd)
subprocess.CalledProcessError: Command '['/opt/hostedtoolcache/Python/3.10.2/x64/bin/python', '-m', 'virtualenv', '--seeder', 'pip', '/home/runner/work/circuitpython/circuitpython/.idf_tools/python_env/idf4.4_py3.10_env']' returned non-zero exit status 1.
Error: Process completed with exit code 1.

@microdev1
Copy link
Collaborator Author

microdev1 commented Jan 25, 2022

@microdev1 any idea what's going wrong with the espressif builds in some of these PRs?

I don't know what's wrong but it seems to be fixed in #5923.

@microdev1 microdev1 requested a review from dhalbert January 26, 2022 17:42
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for following up so quickly on the issue! It will get exercised at some point.

@dhalbert dhalbert merged commit 78781c6 into adafruit:main Jan 26, 2022
@microdev1 microdev1 deleted the ci branch January 27, 2022 05:30
@dhalbert
Copy link
Collaborator

Woot! Looks like this worked: https://github.com/adafruit/circuitpython/actions/runs/1759724741

I merged one PR, a translations PR started up, and then I merged another PR, which triggered the translations PR again, and the first one got canceled.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automatic cancellation of superseded CI builds CI Optimization
3 participants