Skip to content

espressif: Add ESP32-S3-DevKitM-1 board support #5963

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 22, 2022

Conversation

arturo182
Copy link
Collaborator

@arturo182 arturo182 commented Feb 1, 2022

Based on the ESP32-S3-DevKitC-1-N8 board files. Verified on the actual HW.

Requested the PID here: espressif/usb-pids#34

Pinout for reference: https://docs.espressif.com/projects/esp-idf/en/latest/esp32s3/_images/ESP32-S3_DevKitM-1_pinlayout.jpg

@anecdata
Copy link
Member

anecdata commented Feb 2, 2022

Is this different than https://circuitpython.org/board/espressif_esp32s3_devkitc_1_n8/ ?

Edit: Sorry, missed the "M". Espressif board designations are convoluted.

Espressif may balk at separate PID, although the pinout is different rather than just flash / PSRAM variations.

@arturo182
Copy link
Collaborator Author

Let's see, if they disagree then I'll just change it to use the DevKitC PID :)

@prplz
Copy link

prplz commented Feb 3, 2022

You should add IO40 (see #5975)

@jepler
Copy link

jepler commented Feb 16, 2022

They've previously asked us to use the same USB VID/PID for "similar" boards (varying only in flash/psram capacity), let us know if you need help modifying tools/ci_check_duplicate_usb_vid_pid.py to make this OK with the CI.

@arturo182
Copy link
Collaborator Author

espressif/usb-pids#34 got merged so we can merge this too now :)

Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would you mind adding _n8 to the end of the board name? I know the dev board only has one module it comes with now but I wouldn't be surprised if espressif made another mini module later and put it on the same board. Adding the n8 would allow us to distinguish it in the future.

@arturo182
Copy link
Collaborator Author

Should I also add -N8 to MICROPY_HW_BOARD_NAME and USB_PRODUCT ?

@tannewt
Copy link
Member

tannewt commented Feb 18, 2022

Should I also add -N8 to MICROPY_HW_BOARD_NAME and USB_PRODUCT ?

Sure! It's easy to change those after the fact. The board name is trickier since we use it as an id.

@arturo182 arturo182 requested a review from tannewt February 19, 2022 01:37
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@tannewt tannewt merged commit 85b53ea into adafruit:main Feb 22, 2022
@arturo182 arturo182 deleted the esp32-s3-devkitm-1 branch February 23, 2022 01:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants