-
Notifications
You must be signed in to change notification settings - Fork 1.3k
espressif: Add ESP32-S3-DevKitM-1 board support #5963
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Is this different than https://circuitpython.org/board/espressif_esp32s3_devkitc_1_n8/ ? Edit: Sorry, missed the "M". Espressif board designations are convoluted. Espressif may balk at separate PID, although the pinout is different rather than just flash / PSRAM variations. |
Let's see, if they disagree then I'll just change it to use the DevKitC PID :) |
You should add IO40 (see #5975) |
They've previously asked us to use the same USB VID/PID for "similar" boards (varying only in flash/psram capacity), let us know if you need help modifying |
espressif/usb-pids#34 got merged so we can merge this too now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would you mind adding _n8
to the end of the board name? I know the dev board only has one module it comes with now but I wouldn't be surprised if espressif made another mini module later and put it on the same board. Adding the n8 would allow us to distinguish it in the future.
Should I also add |
Sure! It's easy to change those after the fact. The board name is trickier since we use it as an id. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
Based on the ESP32-S3-DevKitC-1-N8 board files. Verified on the actual HW.
Requested the PID here: espressif/usb-pids#34
Pinout for reference: https://docs.espressif.com/projects/esp-idf/en/latest/esp32s3/_images/ESP32-S3_DevKitM-1_pinlayout.jpg