Skip to content

Unexpected maker s3 fixes #5991

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 8, 2022
Merged

Unexpected maker s3 fixes #5991

merged 3 commits into from
Feb 8, 2022

Conversation

prplz
Copy link

@prplz prplz commented Feb 8, 2022

Some pin corrections on unexpected maker's new boards. I've run them by @UnexpectedMaker and he says it's all good.

UnexpectedMaker
UnexpectedMaker approved these changes Feb 8, 2022
View reviewed changes
Copy link

@UnexpectedMaker UnexpectedMaker left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changes look good to me, thanks for picking up these issues!

dhalbert
dhalbert approved these changes Feb 8, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the changes and the vetting!

@dhalbert dhalbert merged commit fd2cbc0 into adafruit:main Feb 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@UnexpectedMaker UnexpectedMaker UnexpectedMaker approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@prplz @dhalbert @UnexpectedMaker