Fix press any key responding slowly on espressif #6046
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jepler
approved these changes
Feb 17, 2022
tannewt
approved these changes
Feb 17, 2022
tannewt
pushed a commit
that referenced
this pull request
Feb 19, 2022
Some toolchains will have string.h defining various macros which can lead to compile errors for string function implementations. Not including string.h fixes this. An implementation of __memcpy_chk is provided for toolchains that enable _FORTIFY_SOURCE. Fixes issue #6046. Signed-off-by: Alexey 'alexxy' Shvetsov <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On espressif, responding to
Press any key to enter the REPL. Use CTRL-D to reloadis delayed (for any key other than ctrl+c).The cause is
port_idle_until_interruptnot waking up on any keys pressed. On other ports, a usb interrupt will wake the loop up, but on espressif, this a FreeRTOS task that is awoken upon ctrl+c being received by tinyusb.My workaround is a little hacky, but shouldn't cause any issues as far as I can tell.