Skip to content

Added board definition for upcoming Pimoroni servo driver. #6197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2022

Conversation

ZodiusInfuser
Copy link

@ZodiusInfuser ZodiusInfuser commented Mar 24, 2022

A teaser can be seen here 🙂
https://twitter.com/i/status/1489298380270575616

With any luck we'll be launching next week

@ZodiusInfuser ZodiusInfuser marked this pull request as draft March 24, 2022 18:29
@ZodiusInfuser ZodiusInfuser marked this pull request as ready for review March 24, 2022 18:46
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good luck with the launch! 🚀

@tannewt tannewt merged commit 9d4c74a into adafruit:main Mar 24, 2022
@ZodiusInfuser
Copy link
Author

ZodiusInfuser commented Mar 24, 2022

Thanks! I thought you were on leave though 😉

@tannewt
Copy link
Member

tannewt commented Mar 24, 2022

Soon!

@ZodiusInfuser
Copy link
Author

ZodiusInfuser commented Mar 25, 2022

Thanks for the merge! Though .... I've just re-compared the pinout to the schematic and LED_DAT should be LED_DATA 🤦. Do I need to raise a separate PR for that, or can the change be merged again if I just update this branch?

Also, we have the 3 ADC pins labelled ADC0, ADC1, and ADC2 in the schematic, but A0, A1, and A2 in the pin def. I believe that's to be consistent with CircuitPython's typical naming so probably doesn't need changing 🤷 .
Actually, scratch that. The pin labels on the board silk say A0, A1, and A2, so it's fine.

@ladyada
Copy link
Member

ladyada commented Mar 29, 2022

once merged a PR cannot be amended. make a new PR plz

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants