Skip to content

Improve argument checking & reduce strings to translate #6522

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 25, 2022

Conversation

jepler
Copy link

@jepler jepler commented Jun 23, 2022

This needs to be tested, it's only compile-tested.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One suggestion, otherwise these look ok to me. Thanks for doing this. I didn't concentrate on these when I squeezed the other messages because these are used (mostly?) on boards with plenty of flash.

@jepler jepler marked this pull request as ready for review September 22, 2022 13:36
@jepler jepler requested a review from dhalbert September 22, 2022 13:36
@jepler
Copy link
Author

jepler commented Sep 22, 2022

I ended up rebasing it, was getting weird conflicts but they're gone now.

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK, looks good, thanks for this cleanup and space saving!

@dhalbert dhalbert merged commit a7b10d4 into adafruit:main Sep 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants