Skip to content

Add register library topic to design guide #6726

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 11, 2022

Conversation

tannewt
Copy link
Member

@tannewt tannewt commented Aug 9, 2022

No description provided.

@tannewt tannewt requested review from caternuson and dhalbert August 9, 2022 19:59
dhalbert
dhalbert previously approved these changes Aug 10, 2022
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the examples. @caternuson look over too; I myself have never written a register-based driver.

@caternuson
Copy link

Thanks for writing this and updating this usage guidance.

Worth adding verbiage that it's also specific to being over I2C? Add mention of the SPI version?

When possible, use it for unpacking and packing registers.

Is there an easy example that could be added for when it would not be possible?

@caternuson
Copy link

Thanks! Looks good. I think having the counter example really helps.

@dhalbert dhalbert merged commit 3347ee6 into adafruit:main Aug 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants