Espressif pwmout reset fixes #6898
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gamblor21
reviewed
Sep 13, 2022
There was a problem hiding this comment.
Tried this on a funhouse both with the automatic and manually creating the display. Works fine now (manual test I set the frequency back to 500Hz just to ensure that was gone).
Side note: is there a reason the funhouse SPI frequency is so low compared to other boards? Not related to this PR but noticed it while reviewing.
|
@jepler @gamblor21 Just need another review. Latest commit is just the merge commit for the fix to the camera library. The code is the same. |
gamblor21
approved these changes
Sep 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes Brightness is zero on startup on FunHouse, Feather ESP32-S3, etc. #6896.
The logic in
pwmout_reset()was not checking the "never reset" flags for PWMOut correctly. It was partly the inverse of what it should have been. Fix this. The display brightness PWMOut was being reset multiple times due to this.esp32-cameracode was resetting LEDC channel 0 clock by mistake, causing dark display on ESP32-S2 TFT.Removed some power-pin-reset bug workaround code which may or may not have been necessary due to this bug.
Reordered display initialization in
main()to avoidpwmout_reset()calls inboard.cfiles.Removed unnecessary "never reset pin" calls in
board.cfiles. The display constructor does this already.@jepler I have a PR into
esp32-camera, and this refers to that tenative commit, but you may want to fix this a different way.