Skip to content

Update pin order to match silk. #6953

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Sep 27, 2022
Merged

Update pin order to match silk. #6953

merged 2 commits into from
Sep 27, 2022

Conversation

kattni
Copy link

@kattni kattni commented Sep 27, 2022

Also added some spaces in to differentiate pin groups more clearly.

@kattni kattni requested review from jepler and dhalbert September 27, 2022 19:25
dhalbert
dhalbert requested changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a blank line between each set of aliased pin names? I've done that elsewhere and I think it's a bit easier to read

@kattni
Copy link
Author

kattni commented Sep 27, 2022

@dhalbert Spacing added as requested.

dhalbert
dhalbert approved these changes Sep 27, 2022
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, great!

@dhalbert dhalbert merged commit 4b89b60 into adafruit:main Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

@jepler jepler Awaiting requested review from jepler

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kattni @dhalbert