Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Saves about 112 bytes on non-Express M0 builds:
MpyError
exception, which wasn't used anywhere by us (EDIT: At one time it was used to display a RGB LED status color to indicate incompatible .mpy files. However, that was removed when the RGB status indicators were simplified.)reset_pin_number()
in atmel-samd I2C. These calls are done in the deinit code, and don't need to be done before deinit is called.mp_printf()
calls tomp_cprintf()
with a translated string. I tried this in a number of places, and the only significant difference was the on inmain.c
. Very surprisingly, this change inrun_boot_py()
saves about 60 bytes:Both
"UID:"
and"%02X"
must be translated to get the savings. If either one is omitted, the savings is much less. I looked at the assembly output, and it might be doing a better job of optimization, but I'm not sure why. Or something in the translation table construction reaches some inflection point. It's very odd. Neither string will need to actually be translated by the translators.This will allow most but not all boards that are failing in #6923 to fit.