Skip to content

Implement async wifi connection on picow #7076

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 18, 2022
Merged

Conversation

bill88t
Copy link

@bill88t bill88t commented Oct 17, 2022

Fixes #7066.
Works*.

*Though for some reason cyw43_wifi_link_status, instead of returning CYW43_LINK_UP, returns CYW43_LINK_JOIN, even though we have ip and internet.
And while connecting, CYW43_LINK_JOIN is returned too..
So I have to wait for the timeout.

@bill88t
Copy link
Author

bill88t commented Oct 17, 2022

Ah I should've been using cyw43_tcpip_link_status, fixed.

@bill88t bill88t marked this pull request as ready for review October 17, 2022 15:34
@jepler
Copy link

jepler commented Oct 17, 2022

@BiffoBear can you test with the artifacts from this PR? they should be ready in an hour or so. If you're not familiar with how to get artifacts from a PR build let me know and I'll add more verbose instructions.

@bill88t
Copy link
Author

bill88t commented Oct 17, 2022

Just so it's clear, I did test it. Usb appears just fine and serial is connectable.
I added a print("ok") after the connection, and I get to see it.

@BiffoBear
Copy link

@BiffoBear can you test with the artifacts from this PR? they should be ready in an hour or so. If you're not familiar with how to get artifacts from a PR build let me know and I'll add more verbose instructions.

I'm happy to test for you, but I've never got artifacts from a PR build before. So I will appreciate your instructions.

Also note that I won't be able to perform the tests for about 12 hours from the time of this post.

@dhalbert
Copy link
Collaborator

I'm happy to test for you, but I've never got artifacts from a PR build before. So I will appreciate your instructions.

Click on the "Details" link on a board build below.
image

Then click on the Summary link:
image

Then scroll on the Summary page to see the "Artifacts section:
image

Then you download the artifact .zip for the board, and extract the build you want from it.

Copy link

@jepler jepler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I tested this and it still connects. I never had the problem of losing the USB connection, but it stands to reason that this change will address that. Even if it doesn't, this is a step in the right direction. Thank you!

@jepler jepler merged commit 6e350a6 into adafruit:main Oct 18, 2022
@BiffoBear
Copy link

I'm happy to test for you, but I've never got artifacts from a PR build before. So I will appreciate your instructions.

Click on the "Details" link on a board build below. ![image](https://user-...

Hi Dan,

Thanks for taking the time to post these instructions. I didn't get to use them this time, but I've stored them for future reference and I'll play with them a bit, so I can learn a new skill.

@bill88t bill88t deleted the early-wifi branch October 20, 2022 17:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to mount CIRCUITPY drive from Pico W after accessing wifi.
4 participants