Skip to content

pico w: implement sslsocket bind, listen, accept #7122

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 28, 2022

Conversation

jepler
Copy link

@jepler jepler commented Oct 25, 2022

This works! Before it was broken with high probability due to adafruit/Adafruit_CircuitPython_HTTPServer#19 -- make sure you have that fix when testing.

https-server-example.zip includes a self-signed certificate for example.com from https://regery.com/en/security/ssl-tools/self-signed-certificate-generator. In my setup I could use a properly trusted certificate, but it would not be OK or useful to attach that certificate and private key to this PR.

Note that it takes quite some time for the picow to do all the things -- about 7.5s to curl the tiny index file. it's not practical. but it does work.

With the self-signed certificate you can test with curl --insecure. Note that curl -insecure (one dash) is accepted but doesn't work!

In Firefox browser with proper certificate:
image

In Firefox browser with self-signed certificate, after clicking through security dialogs:
image

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

People have reported using this, so I'll merge. Thanks!

@dhalbert dhalbert merged commit 4e20049 into adafruit:main Oct 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants