Rework the analogbufio API. #7294
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* read() is now readinto() and takes the buffer to write into. * readinto() returns the number of valid samples. * readinto() can be interrupted by ctrl-c. * readinto() API doesn't support signed numbers because it never did. * sample_rate is now required in the constructor because supported values will vary per-port. * 16 bit values are full range. 12 bit samples from RP2040 are stretched in the same way they are for AnalogIn. Fixes micropython#7226
|
@latkinso42 Please review as well. |
dhalbert
requested changes
Dec 2, 2022
|
Ok, I've made the changes. |
|
Thanks, will test on hw now. |
dhalbert
approved these changes
Dec 2, 2022
There was a problem hiding this comment.
I tested on a Feather RP2040, connecting A0 and A1 to ground and 3.3V. I tested both 8 and 16-bit reads. The values I read are in the range I expect, but are surprisingly noisy, which is weird. I tried samples rates of 1000-664000. But plain old AnalogIn also seems to be noisy. So I think the module is working fine, but we might want to look at whether we are setting up the ADC properly in general.
Pinging @latkinso42 here too.
In any case, thanks for the API improvements!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #7226