Skip to content

Fix duplicate ulab help #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 17, 2023
Merged

Fix duplicate ulab help #7601

merged 1 commit into from
Feb 17, 2023

Conversation

jepler
Copy link

@jepler jepler commented Feb 17, 2023 •
edited
Loading

Closes: #7600

@jepler
don't explicitly register ulab here
d249af2 
.. it is registered by MP_REGISTER_MODULE in ulab.

Closes: adafruit#7600
@jepler jepler changed the base branch from main to 8.0.x February 17, 2023 15:22
@jepler jepler requested a review from dhalbert February 17, 2023 15:22
dhalbert
dhalbert approved these changes Feb 17, 2023
View reviewed changes
Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix!

@jepler
Copy link
Author

jepler commented Feb 17, 2023

@bill88t maybe you can give this a quick test?

@bill88t
Copy link

bill88t commented Feb 17, 2023

On it.

@bill88t
Copy link

bill88t commented Feb 17, 2023

The issue is fixed.

@tannewt tannewt merged commit c7f485d into adafruit:8.0.x Feb 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dhalbert dhalbert dhalbert approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jepler @bill88t @dhalbert @tannewt