Skip to content

Fix for pulsein on Espressif boards #7841

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

Fix for pulsein on Espressif boards #7841

wants to merge 1 commit into from

Conversation

DavePutz
Copy link
Collaborator

@DavePutz DavePutz commented Apr 6, 2023

Fix for issues #7742 and #7817. Moving the call to pulsein_background() from port_background_tick() back to port_background_task(); which was changed by commit 1063ec0

@dhalbert dhalbert requested a review from tannewt April 6, 2023 21:13
tannewt
tannewt requested changes Apr 7, 2023
View reviewed changes
Copy link
Member

@tannewt tannewt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I definitely broke this with #7497 but I don't think this is the right fix. I'll make a PR shortly with what I think the fix is. (There is a port_background_task() call that should have been renamed to tick.)

@tannewt
Copy link
Member

tannewt commented Apr 7, 2023

Ok, I opened #7845.

@microdev1 microdev1 closed this Apr 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tannewt tannewt tannewt requested changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@DavePutz @tannewt @microdev1