Bug fixes for analogbufio espressif implementation #7879
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2. Scaling the 12-bit values received from DMA engine to 16-bit value
|
Q: do these changes match up (attenuation included), with the values returned by |
Yes, the changes match up with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changed attenuation value from ADC_ATTEN_DB_0 to ADC_ATTEN_DB_11. This change increases the measurable input voltage range from range of 100 mV - 950 mV to range of 150 mV - 2450 mV. Reference: https://docs.espressif.com/projects/esp-idf/en/v4.4.4/esp32/api-reference/peripherals/adc.html#adc-attenuation
Scaling the 12-bit values received from ADC DMA engine to 16-bit value before returning the data. This change makes the values returned via
anlogbufio.readintocall 16-bit values similar to 16-bit values returned by analogio module implementation.