Skip to content

Three small changes #8187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
70 changes: 16 additions & 54 deletions locale/circuitpython.pot
Original file line number Diff line number Diff line change
Expand Up @@ -126,8 +126,10 @@ msgstr ""

#: ports/espressif/common-hal/espulp/ULP.c
#: ports/mimxrt10xx/common-hal/audiobusio/__init__.c
#: ports/mimxrt10xx/common-hal/usb_host/Port.c
#: ports/raspberrypi/common-hal/picodvi/Framebuffer.c
#: ports/raspberrypi/common-hal/rp2pio/StateMachine.c
#: ports/raspberrypi/common-hal/usb_host/Port.c
#: shared-bindings/digitalio/DigitalInOut.c
#: shared-bindings/microcontroller/Pin.c
msgid "%q in use"
Expand Down Expand Up @@ -182,6 +184,7 @@ msgid "%q must be 1 when %q is True"
msgstr ""

#: py/argcheck.c shared-bindings/gifio/GifWriter.c
#: shared-module/gifio/OnDiskGif.c
msgid "%q must be <= %d"
msgstr ""

Expand Down Expand Up @@ -779,10 +782,6 @@ msgstr ""
msgid "Cannot subclass slice"
msgstr ""

#: shared-module/bitbangio/SPI.c
msgid "Cannot transfer without MOSI and MISO pins"
msgstr ""

#: shared-bindings/pwmio/PWMOut.c
msgid "Cannot vary frequency on a timer that is already in use"
msgstr ""
Expand Down Expand Up @@ -1090,13 +1089,10 @@ msgstr ""
msgid "Half duplex SPI is not implemented"
msgstr ""

#: ports/mimxrt10xx/common-hal/busio/SPI.c ports/stm/common-hal/busio/I2C.c
#: ports/stm/common-hal/busio/SPI.c ports/stm/common-hal/canio/CAN.c
#: ports/stm/common-hal/sdioio/SDCard.c
msgid "Hardware busy, try alternative pins"
msgstr ""

#: ports/mimxrt10xx/common-hal/busio/UART.c ports/stm/common-hal/busio/UART.c
#: ports/mimxrt10xx/common-hal/busio/SPI.c
#: ports/mimxrt10xx/common-hal/busio/UART.c ports/stm/common-hal/busio/I2C.c
#: ports/stm/common-hal/busio/SPI.c ports/stm/common-hal/busio/UART.c
#: ports/stm/common-hal/canio/CAN.c ports/stm/common-hal/sdioio/SDCard.c
msgid "Hardware in use, try alternative pins"
msgstr ""

Expand Down Expand Up @@ -1355,14 +1351,6 @@ msgstr ""
msgid "Mismatched swap flag"
msgstr ""

#: ports/mimxrt10xx/common-hal/busio/SPI.c
msgid "Missing MISO or MOSI Pin"
msgstr ""

#: ports/stm/common-hal/busio/SPI.c
msgid "Missing MISO or MOSI pin"
msgstr ""

#: ports/raspberrypi/common-hal/rp2pio/StateMachine.c
#, c-format
msgid "Missing first_in_pin. Instruction %d reads pin(s)"
Expand Down Expand Up @@ -1436,6 +1424,14 @@ msgid "Nimble out of memory"
msgstr ""

#: ports/atmel-samd/common-hal/busio/UART.c
#: ports/espressif/common-hal/busio/SPI.c
#: ports/espressif/common-hal/busio/UART.c
#: ports/mimxrt10xx/common-hal/busio/SPI.c
#: ports/mimxrt10xx/common-hal/busio/UART.c ports/nrf/common-hal/busio/UART.c
#: ports/raspberrypi/common-hal/busio/UART.c ports/stm/common-hal/busio/SPI.c
#: ports/stm/common-hal/busio/UART.c shared-bindings/displayio/FourWire.c
#: shared-bindings/displayio/I2CDisplay.c
#: shared-bindings/paralleldisplay/ParallelBus.c shared-module/bitbangio/SPI.c
msgid "No %q pin"
msgstr ""

Expand Down Expand Up @@ -1469,36 +1465,6 @@ msgstr ""
msgid "No IP"
msgstr ""

#: ports/espressif/common-hal/busio/SPI.c
#: ports/mimxrt10xx/common-hal/busio/SPI.c
msgid "No MISO Pin"
msgstr ""

#: ports/stm/common-hal/busio/SPI.c shared-module/bitbangio/SPI.c
msgid "No MISO pin"
msgstr ""

#: ports/espressif/common-hal/busio/SPI.c
#: ports/mimxrt10xx/common-hal/busio/SPI.c
msgid "No MOSI Pin"
msgstr ""

#: ports/stm/common-hal/busio/SPI.c shared-module/bitbangio/SPI.c
msgid "No MOSI pin"
msgstr ""

#: ports/espressif/common-hal/busio/UART.c
#: ports/mimxrt10xx/common-hal/busio/UART.c ports/nrf/common-hal/busio/UART.c
#: ports/raspberrypi/common-hal/busio/UART.c ports/stm/common-hal/busio/UART.c
msgid "No RX pin"
msgstr ""

#: ports/espressif/common-hal/busio/UART.c
#: ports/mimxrt10xx/common-hal/busio/UART.c ports/nrf/common-hal/busio/UART.c
#: ports/raspberrypi/common-hal/busio/UART.c ports/stm/common-hal/busio/UART.c
msgid "No TX pin"
msgstr ""

#: ports/atmel-samd/common-hal/frequencyio/FrequencyIn.c
msgid "No available clocks"
msgstr ""
Expand Down Expand Up @@ -2405,6 +2371,7 @@ msgstr ""
#: ports/espressif/boards/m5stack_core_basic/mpconfigboard.h
#: ports/espressif/boards/m5stack_core_fire/mpconfigboard.h
#: ports/espressif/boards/m5stack_stick_c/mpconfigboard.h
#: ports/espressif/boards/m5stack_stick_c_plus/mpconfigboard.h
msgid "You pressed button A at start up."
msgstr ""

Expand Down Expand Up @@ -3628,11 +3595,6 @@ msgstr ""
msgid "no module named '%q'"
msgstr ""

#: shared-bindings/displayio/FourWire.c shared-bindings/displayio/I2CDisplay.c
#: shared-bindings/paralleldisplay/ParallelBus.c
msgid "no reset pin available"
msgstr ""

#: shared-module/sdcardio/SDCard.c
msgid "no response from SD card"
msgstr ""
Expand Down
4 changes: 2 additions & 2 deletions ports/broadcom/common-hal/busio/UART.c
Original file line number Diff line number Diff line change
Expand Up @@ -352,7 +352,7 @@ void common_hal_busio_uart_deinit(busio_uart_obj_t *self) {
// Write characters.
size_t common_hal_busio_uart_write(busio_uart_obj_t *self, const uint8_t *data, size_t len, int *errcode) {
if (self->tx_pin == NULL) {
mp_raise_ValueError(translate("No TX pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_tx);
}

COMPLETE_MEMORY_READS;
Expand Down Expand Up @@ -400,7 +400,7 @@ STATIC void enable_interrupt(busio_uart_obj_t *self) {
// Read characters.
size_t common_hal_busio_uart_read(busio_uart_obj_t *self, uint8_t *data, size_t len, int *errcode) {
if (self->rx_pin == NULL) {
mp_raise_ValueError(translate("No RX pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_rx);
}

if (len == 0) {
Expand Down
8 changes: 4 additions & 4 deletions ports/espressif/common-hal/busio/SPI.c
Original file line number Diff line number Diff line change
Expand Up @@ -186,15 +186,15 @@ void common_hal_busio_spi_unlock(busio_spi_obj_t *self) {
bool common_hal_busio_spi_write(busio_spi_obj_t *self,
const uint8_t *data, size_t len) {
if (self->MOSI == NULL) {
mp_raise_ValueError(translate("No MOSI Pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_mosi);
}
return common_hal_busio_spi_transfer(self, data, NULL, len);
}

bool common_hal_busio_spi_read(busio_spi_obj_t *self,
uint8_t *data, size_t len, uint8_t write_value) {
if (self->MISO == NULL) {
mp_raise_ValueError(translate("No MISO Pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_miso);
}
if (self->MOSI == NULL) {
return common_hal_busio_spi_transfer(self, NULL, data, len);
Expand All @@ -210,10 +210,10 @@ bool common_hal_busio_spi_transfer(busio_spi_obj_t *self,
return true;
}
if (self->MOSI == NULL && data_out != NULL) {
mp_raise_ValueError(translate("No MOSI Pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_mosi);
}
if (self->MISO == NULL && data_in != NULL) {
mp_raise_ValueError(translate("No MISO Pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_miso);
}

spi_transaction_t transactions[MAX_SPI_TRANSACTIONS];
Expand Down
4 changes: 2 additions & 2 deletions ports/espressif/common-hal/busio/UART.c
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ void common_hal_busio_uart_deinit(busio_uart_obj_t *self) {
// Read characters.
size_t common_hal_busio_uart_read(busio_uart_obj_t *self, uint8_t *data, size_t len, int *errcode) {
if (self->rx_pin == NULL) {
mp_raise_ValueError(translate("No RX pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_rx);
}
if (len == 0) {
// Nothing to read.
Expand Down Expand Up @@ -357,7 +357,7 @@ size_t common_hal_busio_uart_read(busio_uart_obj_t *self, uint8_t *data, size_t
// Write characters.
size_t common_hal_busio_uart_write(busio_uart_obj_t *self, const uint8_t *data, size_t len, int *errcode) {
if (self->tx_pin == NULL) {
mp_raise_ValueError(translate("No TX pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_tx);
}

size_t left_to_write = len;
Expand Down
13 changes: 8 additions & 5 deletions ports/mimxrt10xx/common-hal/busio/SPI.c
Original file line number Diff line number Diff line change
Expand Up @@ -182,7 +182,7 @@ void common_hal_busio_spi_construct(busio_spi_obj_t *self,
self->spi = mcu_spi_banks[self->clock->bank_idx - 1];
} else {
if (spi_taken) {
mp_raise_ValueError(translate("Hardware busy, try alternative pins"));
mp_raise_ValueError(translate("Hardware in use, try alternative pins"));
} else {
raise_ValueError_invalid_pins();
}
Expand Down Expand Up @@ -331,7 +331,7 @@ bool common_hal_busio_spi_write(busio_spi_obj_t *self,
return true;
}
if (self->mosi == NULL) {
mp_raise_ValueError(translate("No MOSI Pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_mosi);
}

lpspi_transfer_t xfer = { 0 };
Expand All @@ -349,7 +349,7 @@ bool common_hal_busio_spi_read(busio_spi_obj_t *self,
return true;
}
if (self->miso == NULL) {
mp_raise_ValueError(translate("No MISO Pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_miso);
}

LPSPI_SetDummyData(self->spi, write_value);
Expand All @@ -367,8 +367,11 @@ bool common_hal_busio_spi_transfer(busio_spi_obj_t *self, const uint8_t *data_ou
if (len == 0) {
return true;
}
if (self->miso == NULL || self->mosi == NULL) {
mp_raise_ValueError(translate("Missing MISO or MOSI Pin"));
if (self->mosi == NULL && data_out != NULL) {
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_mosi);
}
if (self->miso == NULL && data_in != NULL) {
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_miso);
}

LPSPI_SetDummyData(self->spi, 0xFF);
Expand Down
4 changes: 2 additions & 2 deletions ports/mimxrt10xx/common-hal/busio/UART.c
Original file line number Diff line number Diff line change
Expand Up @@ -401,7 +401,7 @@ void common_hal_busio_uart_deinit(busio_uart_obj_t *self) {
// Read characters.
size_t common_hal_busio_uart_read(busio_uart_obj_t *self, uint8_t *data, size_t len, int *errcode) {
if (self->rx == NULL) {
mp_raise_ValueError(translate("No RX pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_rx);
}

if (len == 0) {
Expand Down Expand Up @@ -458,7 +458,7 @@ size_t common_hal_busio_uart_read(busio_uart_obj_t *self, uint8_t *data, size_t
// Write characters.
size_t common_hal_busio_uart_write(busio_uart_obj_t *self, const uint8_t *data, size_t len, int *errcode) {
if (self->tx == NULL) {
mp_raise_ValueError(translate("No TX pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_tx);
}
if (self->rs485_dir && len) {
GPIO_PinWrite(self->rs485_dir->gpio, self->rs485_dir->number, !self->rs485_invert);
Expand Down
5 changes: 4 additions & 1 deletion ports/mimxrt10xx/mpconfigport.h
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,6 @@ extern uint8_t _ld_filesystem_start;
extern uint8_t _ld_filesystem_end;
extern uint8_t _ld_default_stack_size;

// 20kiB stack
#define CIRCUITPY_DEFAULT_STACK_SIZE ((uint32_t)&_ld_default_stack_size)
#define MICROPY_PY_BUILTINS_NOTIMPLEMENTED (0)
#define MICROPY_PY_FUNCTION_ATTRS (0)
Expand All @@ -47,6 +46,10 @@ extern uint8_t _ld_default_stack_size;
#define CIRCUITPY_INTERNAL_FLASH_FILESYSTEM_START_ADDR ((uint32_t)&_ld_filesystem_start)
#define CIRCUITPY_INTERNAL_FLASH_FILESYSTEM_SIZE ((uint32_t)(&_ld_filesystem_end - &_ld_filesystem_start))

// Allocate 32 bytes at a time instead of the default 16 so that allocated buffers
// are aligned to cache lines.
#define MICROPY_BYTES_PER_GC_BLOCK (32)

#include "py/circuitpy_mpconfig.h"

#define MICROPY_PORT_ROOT_POINTERS \
Expand Down
4 changes: 2 additions & 2 deletions ports/nrf/common-hal/busio/UART.c
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ void common_hal_busio_uart_deinit(busio_uart_obj_t *self) {
// Read characters.
size_t common_hal_busio_uart_read(busio_uart_obj_t *self, uint8_t *data, size_t len, int *errcode) {
if (nrf_uarte_rx_pin_get(self->uarte->p_reg) == NRF_UARTE_PSEL_DISCONNECTED) {
mp_raise_ValueError(translate("No RX pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_rx);
}

uint64_t start_ticks = supervisor_ticks_ms64();
Expand Down Expand Up @@ -347,7 +347,7 @@ size_t common_hal_busio_uart_read(busio_uart_obj_t *self, uint8_t *data, size_t
// Write characters.
size_t common_hal_busio_uart_write(busio_uart_obj_t *self, const uint8_t *data, size_t len, int *errcode) {
if (nrf_uarte_tx_pin_get(self->uarte->p_reg) == NRF_UARTE_PSEL_DISCONNECTED) {
mp_raise_ValueError(translate("No TX pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_tx);
}

if (len == 0) {
Expand Down
4 changes: 2 additions & 2 deletions ports/raspberrypi/common-hal/busio/UART.c
Original file line number Diff line number Diff line change
Expand Up @@ -211,7 +211,7 @@ void common_hal_busio_uart_deinit(busio_uart_obj_t *self) {
// Write characters.
size_t common_hal_busio_uart_write(busio_uart_obj_t *self, const uint8_t *data, size_t len, int *errcode) {
if (self->tx_pin == NO_PIN) {
mp_raise_ValueError(translate("No TX pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_tx);
}

if (self->rs485_dir_pin != NO_PIN) {
Expand Down Expand Up @@ -239,7 +239,7 @@ size_t common_hal_busio_uart_write(busio_uart_obj_t *self, const uint8_t *data,
// Read characters.
size_t common_hal_busio_uart_read(busio_uart_obj_t *self, uint8_t *data, size_t len, int *errcode) {
if (self->rx_pin == NO_PIN) {
mp_raise_ValueError(translate("No RX pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_rx);
}

if (len == 0) {
Expand Down
2 changes: 1 addition & 1 deletion ports/silabs/common-hal/busio/I2C.c
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,7 @@ void common_hal_busio_i2c_construct(busio_i2c_obj_t *self,
common_hal_mcu_pin_claim(sda);
in_used = true;
} else {
mp_raise_ValueError(translate("Hardware busy, try alternative pins"));
mp_raise_ValueError(translate("Hardware in use, try alternative pins"));
}
} else {
raise_ValueError_invalid_pins();
Expand Down
2 changes: 1 addition & 1 deletion ports/silabs/common-hal/busio/SPI.c
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@ void common_hal_busio_spi_construct(busio_spi_obj_t *self,
mp_raise_ValueError(translate("SPI init error"));
}
} else {
mp_raise_ValueError(translate("Hardware busy, try alternative pins"));
mp_raise_ValueError(translate("Hardware in use, try alternative pins"));
}
} else {
raise_ValueError_invalid_pins();
Expand Down
2 changes: 1 addition & 1 deletion ports/silabs/common-hal/busio/UART.c
Original file line number Diff line number Diff line change
Expand Up @@ -131,7 +131,7 @@ void common_hal_busio_uart_construct(busio_uart_obj_t *self,
context = self;

} else {
mp_raise_ValueError(translate("Hardware busy, try alternative pins"));
mp_raise_ValueError(translate("Hardware in use, try alternative pins"));
}

} else {
Expand Down
2 changes: 1 addition & 1 deletion ports/stm/common-hal/busio/I2C.c
Original file line number Diff line number Diff line change
Expand Up @@ -117,7 +117,7 @@ void common_hal_busio_i2c_construct(busio_i2c_obj_t *self,
I2Cx = mcu_i2c_banks[self->sda->periph_index - 1];
} else {
if (i2c_taken) {
mp_raise_ValueError(translate("Hardware busy, try alternative pins"));
mp_raise_ValueError(translate("Hardware in use, try alternative pins"));
} else {
raise_ValueError_invalid_pins();
}
Expand Down
15 changes: 9 additions & 6 deletions ports/stm/common-hal/busio/SPI.c
Original file line number Diff line number Diff line change
Expand Up @@ -160,7 +160,7 @@ STATIC int check_pins(busio_spi_obj_t *self,
}

if (spi_taken) {
mp_raise_ValueError(translate("Hardware busy, try alternative pins"));
mp_raise_ValueError(translate("Hardware in use, try alternative pins"));
} else {
raise_ValueError_invalid_pin();
}
Expand Down Expand Up @@ -347,7 +347,7 @@ void common_hal_busio_spi_unlock(busio_spi_obj_t *self) {
bool common_hal_busio_spi_write(busio_spi_obj_t *self,
const uint8_t *data, size_t len) {
if (self->mosi == NULL) {
mp_raise_ValueError(translate("No MOSI pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_mosi);
}
HAL_StatusTypeDef result = HAL_SPI_Transmit(&self->handle, (uint8_t *)data, (uint16_t)len, HAL_MAX_DELAY);
return result == HAL_OK;
Expand All @@ -356,9 +356,9 @@ bool common_hal_busio_spi_write(busio_spi_obj_t *self,
bool common_hal_busio_spi_read(busio_spi_obj_t *self,
uint8_t *data, size_t len, uint8_t write_value) {
if (self->miso == NULL && !self->half_duplex) {
mp_raise_ValueError(translate("No MISO pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_miso);
} else if (self->half_duplex && self->mosi == NULL) {
mp_raise_ValueError(translate("No MOSI pin"));
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_mosi);
}
HAL_StatusTypeDef result = HAL_OK;
if ((!self->half_duplex && self->mosi == NULL) || (self->half_duplex && self->mosi != NULL && self->miso == NULL)) {
Expand All @@ -372,8 +372,11 @@ bool common_hal_busio_spi_read(busio_spi_obj_t *self,

bool common_hal_busio_spi_transfer(busio_spi_obj_t *self,
const uint8_t *data_out, uint8_t *data_in, size_t len) {
if (self->miso == NULL || self->mosi == NULL) {
mp_raise_ValueError(translate("Missing MISO or MOSI pin"));
if (self->mosi == NULL && data_out != NULL) {
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_mosi);
}
if (self->miso == NULL && data_in != NULL) {
mp_raise_ValueError_varg(translate("No %q pin"), MP_QSTR_miso);
}
HAL_StatusTypeDef result = HAL_SPI_TransmitReceive(&self->handle,
(uint8_t *)data_out, data_in, (uint16_t)len,HAL_MAX_DELAY);
Expand Down
Loading