pycamera: backlight, solarize #8245
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
while developing esp-camera I had the problem that firmware.elf was not regenerated if the only file I edited was in the esp32-camera submodule. By telling make that $(IDF_CMAKE_TARGETS), the list of .a fliles produced by ninja-building esp-idf, depend on esp-idf-stamp and that firmware.elf in turn depends on these files, the ninja build is re-run on each make, which is reasonably quick if nothing needs to be rebuilt.
the backlight situation will be revisited with the next board prototype, but it's good to prove this can be done. Depends on adafruit/esp32-camera#6 which should be merged before this.
jepler
added a commit
to adafruit/Adafruit_CircuitPython_PyCamera
that referenced
this pull request
Aug 2, 2023
Needs adafruit/circuitpython#8245 to work
|
I could rewrite the i2c initialization code to use common hal but it was nice that I could essentially copy & paste the code out of tinyuf2 |
tannewt
approved these changes
Aug 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.