-
Notifications
You must be signed in to change notification settings - Fork 1.3k
add OV2640 support to sdkconfig for esp32s3_eye build #8901
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Do we want to update this instead? https://github.com/adafruit/circuitpython/blob/main/ports/espressif/esp-idf-config/sdkconfig.defaults#L113-L125 That's the global setting for camera support. |
That probably makes sense. It is confusing. Where does OV5640 get enabled? It seems like it is globally enabled but I don't see it in there. |
for example, I just built the esp32s3_metro and in the generated sdkconfig it has
but the sdkconfig in boards/adafruit_metro_esp32s3 does not have any camera specified. It would probably be good to get bot the OV5640 and OV2640 here as well |
It is on by default in the kconfig: https://github.com/espressif/esp32-camera/blob/master/Kconfig#L40 With 9.x we only include non-default settings in our kconfigs. |
but in line 26 https://github.com/espressif/esp32-camera/blob/master/Kconfig#L26 OV2640 is also enabled, but we don't get it without specifying it... |
Yes, I am confused by why the |
The |
fixes #8883