Skip to content

add OV2640 support to sdkconfig for esp32s3_eye build #8901

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 11, 2024
Merged

add OV2640 support to sdkconfig for esp32s3_eye build #8901

merged 1 commit into from
Feb 11, 2024

Conversation

jerryneedell
Copy link
Collaborator

fixes #8883

Copy link
Collaborator

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@dhalbert dhalbert merged commit 38b45f5 into adafruit:main Feb 11, 2024
@jerryneedell jerryneedell deleted the jerryn_eye branch February 11, 2024 20:33
@tannewt
Copy link
Member

tannewt commented Feb 12, 2024

Do we want to update this instead? https://github.com/adafruit/circuitpython/blob/main/ports/espressif/esp-idf-config/sdkconfig.defaults#L113-L125 That's the global setting for camera support.

@jerryneedell
Copy link
Collaborator Author

jerryneedell commented Feb 12, 2024

That probably makes sense. It is confusing. Where does OV5640 get enabled? It seems like it is globally enabled but I don't see it in there.

@jerryneedell
Copy link
Collaborator Author

jerryneedell commented Feb 12, 2024

for example, I just built the esp32s3_metro and in the generated sdkconfig it has

# CONFIG_OV7670_SUPPORT is not set
CONFIG_OV7725_SUPPORT=y
# CONFIG_NT99141_SUPPORT is not set
# CONFIG_OV2640_SUPPORT is not set
CONFIG_OV3660_SUPPORT=y
CONFIG_OV5640_SUPPORT=y

but the sdkconfig in boards/adafruit_metro_esp32s3 does not have any camera specified. It would probably be good to get bot the OV5640 and OV2640 here as well

@tannewt
Copy link
Member

tannewt commented Feb 12, 2024

That probably makes sense. It is confusing. Where does OV5640 get enabled? It seems like it is globally enabled but I don't see it in there.

It is on by default in the kconfig: https://github.com/espressif/esp32-camera/blob/master/Kconfig#L40

With 9.x we only include non-default settings in our kconfigs.

@jerryneedell
Copy link
Collaborator Author

That probably makes sense. It is confusing. Where does OV5640 get enabled? It seems like it is globally enabled but I don't see it in there.

It is on by default in the kconfig: https://github.com/espressif/esp32-camera/blob/master/Kconfig#L40

With 9.x we only include non-default settings in our kconfigs.

but in line 26 https://github.com/espressif/esp32-camera/blob/master/Kconfig#L26 OV2640 is also enabled, but we don't get it without specifying it...

@dhalbert
Copy link
Collaborator

Yes, I am confused by why the Kconfig has them all on by default but we are not seeing that in the generated sdkconfig in the build. Maybe we are not using the esp32-camera Kconfig properly.

@tannewt
Copy link
Member

tannewt commented Feb 12, 2024

The is not set are not actually just comments. They actually set the value to off. See zephyrproject-rtos/zephyr#5443 for background.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

espcamera IDFError with CP 9.0beta.0 -- works OK with CP 8.2.9
3 participants