Skip to content

Make xclk pin optional #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 15, 2022
Merged

Make xclk pin optional #3

merged 1 commit into from
Dec 15, 2022

Conversation

deshipu
Copy link

@deshipu deshipu commented Dec 15, 2022

Some camera modules come with a crystal oscillator that already provides the main clock, and they don't have the xclk/mclk pin. We don't need to initialize the PWM pin then.

Some camera modules come with a crystal oscillator that already provides
the main clock, and they don't have the xclk/mclk pin. We don't need to
initialize the PWM pin then.
@deshipu deshipu requested review from jepler and dhalbert December 15, 2022 21:26
Copy link

@dhalbert dhalbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really know this code at all, but the change looks OK to me. Should this also be submitted upstream?

@dhalbert dhalbert merged commit 0dfa482 into adafruit:master Dec 15, 2022
@deshipu
Copy link
Author

deshipu commented Dec 16, 2022

It relies on another change that was only submitted here, #1, so I don't think so.

@deshipu deshipu mentioned this pull request Dec 16, 2022
@dhalbert
Copy link

I removed this PR by a push -f, since it was done on the wrong branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants