Skip to content

Commit c384377

Browse files
M00nF1shTimothy-Dougherty
authored andcommitted
crd adjustments & webhook-secret name change (kubernetes-sigs#1477)
* crd adjustments * change to aws-load-balancer-webhook-secert
1 parent 22b98a7 commit c384377

File tree

4 files changed

+18
-4
lines changed

4 files changed

+18
-4
lines changed

apis/elbv2/v1alpha1/targetgroupbinding_types.go

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -131,9 +131,11 @@ type TargetGroupBindingStatus struct {
131131
// +kubebuilder:object:root=true
132132
// +kubebuilder:resource:categories=all
133133
// +kubebuilder:subresource:status
134+
// +kubebuilder:printcolumn:name="SERVICE-NAME",type="string",JSONPath=".spec.serviceRef.name",description="The Kubernetes Service's name"
135+
// +kubebuilder:printcolumn:name="SERVICE-PORT",type="string",JSONPath=".spec.serviceRef.port",description="The Kubernetes Service's port"
134136
// +kubebuilder:printcolumn:name="TARGET-TYPE",type="string",JSONPath=".spec.targetType",description="The AWS TargetGroup's TargetType"
135-
// +kubebuilder:printcolumn:name="ARN",type="string",JSONPath=".spec.targetGroupARN",description="The AWS TargetGroup's Amazon Resource Name"
136-
137+
// +kubebuilder:printcolumn:name="ARN",type="string",JSONPath=".spec.targetGroupARN",description="The AWS TargetGroup's Amazon Resource Name",priority=1
138+
// +kubebuilder:printcolumn:name="AGE",type="date",JSONPath=".metadata.creationTimestamp"
137139
// TargetGroupBinding is the Schema for the TargetGroupBinding API
138140
type TargetGroupBinding struct {
139141
metav1.TypeMeta `json:",inline"`

config/certmanager/certificate.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,4 +21,4 @@ spec:
2121
issuerRef:
2222
kind: Issuer
2323
name: selfsigned-issuer
24-
secretName: webhook-server-cert # this secret will not be prefixed, since it's not managed by kustomize
24+
secretName: aws-load-balancer-webhook-secert # this secret will not be prefixed, since it's not managed by kustomize

config/crd/bases/elbv2.k8s.aws_targetgroupbindings.yaml

Lines changed: 12 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -9,14 +9,26 @@ metadata:
99
name: targetgroupbindings.elbv2.k8s.aws
1010
spec:
1111
additionalPrinterColumns:
12+
- JSONPath: .spec.serviceRef.name
13+
description: The Kubernetes Service's name
14+
name: SERVICE-NAME
15+
type: string
16+
- JSONPath: .spec.serviceRef.port
17+
description: The Kubernetes Service's port
18+
name: SERVICE-PORT
19+
type: string
1220
- JSONPath: .spec.targetType
1321
description: The AWS TargetGroup's TargetType
1422
name: TARGET-TYPE
1523
type: string
1624
- JSONPath: .spec.targetGroupARN
1725
description: The AWS TargetGroup's Amazon Resource Name
1826
name: ARN
27+
priority: 1
1928
type: string
29+
- JSONPath: .metadata.creationTimestamp
30+
name: AGE
31+
type: date
2032
group: elbv2.k8s.aws
2133
names:
2234
categories:

config/default/controller_webhook_patch.yaml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -19,4 +19,4 @@ spec:
1919
- name: cert
2020
secret:
2121
defaultMode: 420
22-
secretName: webhook-server-cert
22+
secretName: aws-load-balancer-webhook-secert

0 commit comments

Comments
 (0)