Skip to content

crd adjustments & webhook-secret name change #1477

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 9, 2020
Merged

crd adjustments & webhook-secret name change #1477

merged 2 commits into from
Oct 9, 2020

Conversation

M00nF1sh
Copy link
Collaborator

@M00nF1sh M00nF1sh commented Oct 8, 2020

  1. webhook cert secret name is change from webhook-server-cert to aws-load-balancer-webhook-secert.
  2. add SERVICE-NAME and SERVICE-PORT as TargetGroupBinding's columns.
  3. make ARN a optional field, which will only be disabled with -o wide.

Test done

$ kubectl -n bugbash get targetgroupbindings
NAME                              SERVICE-NAME   SERVICE-PORT   TARGET-TYPE   AGE
k8s-bugbash-echo-d8bb3f11a3       echo           80             instance      20h
k8s-bugbash-echonlb-39038865b0    echo-nlb       80             ip            20h
k8s-bugbash-game2048-acf2b75044   game-2048      80             ip            20h
$ kubectl -n bugbash get targetgroupbindings -o wide
NAME                              SERVICE-NAME   SERVICE-PORT   TARGET-TYPE   ARN                                                                                                                AGE
k8s-bugbash-echo-d8bb3f11a3       echo           80             instance      arn:aws:elasticloadbalancing:us-west-2:283511030707:targetgroup/k8s-bugbash-echo-d8bb3f11a3/089b77777695e2c7       20h
k8s-bugbash-echonlb-39038865b0    echo-nlb       80             ip            arn:aws:elasticloadbalancing:us-west-2:283511030707:targetgroup/k8s-bugbash-echonlb-39038865b0/18d872a85b35f6cb    20h
k8s-bugbash-game2048-acf2b75044   game-2048      80             ip            arn:aws:elasticloadbalancing:us-west-2:283511030707:targetgroup/k8s-bugbash-game2048-acf2b75044/627b464cc155d297   20h

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Oct 8, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: M00nF1sh
To complete the pull request process, please assign after the PR has been reviewed.
You can assign the PR to them by writing /assign in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@@ -21,4 +21,4 @@ spec:
issuerRef:
kind: Issuer
name: selfsigned-issuer
secretName: webhook-server-cert # this secret will not be prefixed, since it's not managed by kustomize
secretName: aws-load-balancer-webhook-server-cert # this secret will not be prefixed, since it's not managed by kustomize
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lets name it aws-load-balancer-webhook-secret since the object is of type secret and will contain info more than certificate.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done :D

@M00nF1sh M00nF1sh merged commit 5c5c58a into kubernetes-sigs:v2_ga Oct 9, 2020
Timothy-Dougherty pushed a commit to adammw/aws-load-balancer-controller that referenced this pull request Nov 9, 2023
* crd adjustments

* change to aws-load-balancer-webhook-secert
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants