Skip to content

feat: update sglang version to include KV event publishing fix #1507

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

faradawn
Copy link
Contributor

@faradawn faradawn commented Jun 13, 2025

Overview:

Update the Sglang version to include KV event publishing fix. Docker build successful. Tested and it is fully functional.

image
2025-06-12T23:42:08.644Z  INFO serve_dynamo.dyn_worker: [SGLangWorker:1] Starting SGLangWorker instance with all registered endpoints   
2025-06-12T23:42:10.618Z  INFO dynamo_llm::discovery::watcher: added model model_name="deepseek-ai/DeepSeek-R1-Distill-Llama-8B"

Details:

Where should the reviewer start?

Related Issues: (use one of the action keywords Closes / Fixes / Resolves / Relates to)

  • closes GitHub issue: #xxx

Summary by CodeRabbit

  • Chores
    • Updated the base AI engine version to include recent fixes and improvements.

Copy link

copy-pr-bot bot commented Jun 13, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

Copy link

👋 Hi faradawn! Thank you for contributing to ai-dynamo/dynamo.

Just a reminder: The NVIDIA Test Github Validation CI runs an essential subset of the testing framework to quickly catch errors.Your PR reviewers may elect to test the changes comprehensively before approving your changes.

🚀

@github-actions github-actions bot added feat external-contribution Pull request is from an external contributor labels Jun 13, 2025
Copy link
Contributor

coderabbitai bot commented Jun 13, 2025

Walkthrough

The Dockerfile for sglang was updated to use a newer commit of the sglang repository. The comment above the commit reference was also expanded to document recent fixes, specifically mentioning a ZMQ KV event publisher fix as of 6/12, while retaining previous notes about earlier improvements.

Changes

File(s) Summary
container/Dockerfile.sglang Updated SGLANG_COMMIT to a newer commit and expanded comment to reflect additional fixes.

Possibly related PRs

Poem

A Dockerfile hops to a newer commit,
With ZMQ fixes—oh, what a hit!
Notes expanded, history kept clear,
Sglang grows stronger with each passing year.
🐇✨


📜 Recent review details

Configuration used: .coderabbit.yaml
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0bba09a and e6f11e4.

📒 Files selected for processing (1)
  • container/Dockerfile.sglang (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (2)
  • GitHub Check: Build and Test - vllm
  • GitHub Check: pre-commit
🔇 Additional comments (1)
container/Dockerfile.sglang (1)

138-140:

❓ Verification inconclusive

Verify updated SGLANG_COMMIT and linked fixes
Please confirm that the new commit hash exists in the sglang repository and indeed includes the ZMQ KV event publisher fix referenced in the comment.


🏁 Script executed:

#!/bin/bash
# Verify that the specified commit exists in the remote sglang repo
git ls-remote https://github.com/sgl-project/sglang.git 777688b8929c877e4e28c2eac208d776abe4c3af

Length of output: 98


Verify SGLANG_COMMIT existence and referenced fixes
The git ls-remote check returned no result for commit 777688b8929c877e4e28c2eac208d776abe4c3af. Please manually confirm that this hash exists in the sgl-project/sglang repo and that it includes both:

  • DP attention–based routing perf fixes
  • ZMQ KV event publisher fix

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
external-contribution Pull request is from an external contributor feat size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant