fix infinite loop with kafka admin #20
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of dpkp#2194
An infinite loop may happen with the following pattern:
self._send_request_to_node(self._client.least_loaded_node(), request)
The problem happens when self._client's cluster metadata is out-of-date, and the
result of least_loaded_node() is a node that has been removed from the cluster but
the client is unware of it. When this happens _send_request_to_node will enter an
infinite loop waiting for the chosen node to become available, which won't happen,
resulting in an infinite loop.
This commit introduces a new method named _send_request_to_least_loaded_node which
handles the case above. This is done by regularly checking if the target node is
available in the cluster metadata, and if not, a new node is chosen.
Notes: