Cross build with Scala 2.13 #121
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks @tmccarthy! |
|
Just tagged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds support for Scala 2.13 and fixes #120.
The only tricky issue I found was with extending
NativeArrayin order to overridegetDefaultValue. I believe that the issue described in scala/bug#11575 is making it impossible to overrideNativeArrayanonymously in Scala code. My solution was to create a new implementation inNativeArrayWithDefault.java. This feels excessive but was the best I could do. I'm open to feedback if there's a cleaner solution to the problem.Hopefully this PR is useful. Let me know if there's any other changes required!