3d Surface Plots #134
Merged
3d Surface Plots #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maxstreese
commented
Nov 22, 2019
Comment on lines
+240
to
+241
| x: Option[Sequence], | ||
| y: Option[Sequence], |
There was a problem hiding this comment.
Turns out that in order to get something like below you need the x and y axes as well. I though you could provide these via the axes in the scene (part of the layout) but you cannot.
|
@maxstreese That's awesome, thanks a lot! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
I have tried to implement as best as possible 3D Surface Plots.
Tests where all passing on my machine after commenting in the relevant section of the Plotly documentation as described in your README. Additionally I have tried to follow your indentation style as close as possible.
To have some idea of how the changes introduced here behave in the real world I have replicated parts of the Plotly documentation. Please see below for the results.
Topographical 3D Surface Plot
Multiple 3D Surface Plots
Some Layout Features