chore(deps-and-node-lts): locks node lts and revert bump deps #1140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Haroenv
reviewed
Apr 17, 2020
Comment on lines
32
to
+39
| "@babel/cli": "7.8.4", | ||
| "@babel/core": "7.9.0", | ||
| "@babel/preset-env": "7.9.5", | ||
| "@babel/preset-typescript": "7.9.0", | ||
| "@microsoft/api-extractor": "7.7.13", | ||
| "@rollup/plugin-alias": "3.1.0", | ||
| "@babel/core": "7.8.7", | ||
| "@babel/preset-env": "7.8.7", | ||
| "@babel/preset-typescript": "7.8.3", | ||
| "@microsoft/api-extractor": "7.7.8", | ||
| "@rollup/plugin-alias": "3.0.1", | ||
| "@rollup/plugin-json": "4.0.2", | ||
| "@rollup/plugin-node-resolve": "7.1.3", | ||
| "@types/jest": "25.2.1", | ||
| "@types/node": "13.11.1", | ||
| "@typescript-eslint/eslint-plugin": "2.28.0", | ||
| "@typescript-eslint/parser": "2.28.0", | ||
| "@rollup/plugin-node-resolve": "7.1.1", |
There was a problem hiding this comment.
I suspect either of the rollup plugins to have caused the regression. Can you try upgrading one at a time to see which is causing it?
Otherwise it could be babel too
There was a problem hiding this comment.
Honestly, it requires a little bit more time than I have right now. So I probably prefer do it later so I can make a release next Monday.
Haroenv
approved these changes
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request locks the usage of the client in node LTS, and reverts the previous bump of dependencies.