Skip to content

feat(createNodeHttpRequester): Add proxy support to another Agent on createNodeHttpRequester #1180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Aug 5, 2020
Merged

feat(createNodeHttpRequester): Add proxy support to another Agent on createNodeHttpRequester #1180

Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
cb84cd5
Adding support do proxy
diogolmenezes Jul 29, 2020
138d1b9
feat(createNodeHttpRequester): Add proxy support to createNodeHttpReq…
diogolmenezes Jul 29, 2020
36e7a0b
Merge branch 'master' of github.com:diogolmenezes/algoliasearch-clien…
diogolmenezes Jul 29, 2020
e045346
feat(createNodeHttpRequester): Add proxy support to createNodeHttpReq…
diogolmenezes Jul 29, 2020
f2a74c0
Merge branch 'master' of github.com:diogolmenezes/algoliasearch-clien…
diogolmenezes Aug 4, 2020
9d58ea7
feat(createNodeHttpRequester): Add proxy support to another agent
diogolmenezes Jul 29, 2020
a99d39c
Merge branch 'master' of github.com:diogolmenezes/algoliasearch-clien…
diogolmenezes Aug 4, 2020
ce9b7d6
change API
Haroenv Aug 5, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 15 additions & 4 deletions packages/requester-node-http/src/createNodeHttpRequester.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,25 @@
/* eslint functional/prefer-readonly-type: 0 */
/* eslint sonarjs/cognitive-complexity: 0 */ // -->

import { Destroyable, Request, Requester, Response } from '@algolia/requester-common';
import * as http from 'http';
import * as https from 'https';
import * as URL from 'url';

export function createNodeHttpRequester(): Requester & Destroyable {
export type NodeHttpRequesterOptions = {
agent?: https.Agent | http.Agent;
httpAgent?: http.Agent;
httpsAgent?: https.Agent;
};

export function createNodeHttpRequester({
agent: userGlobalAgent,
httpAgent: userHttpAgent,
httpsAgent: userHttpsAgent,
}: NodeHttpRequesterOptions = {}): Requester & Destroyable {
const agentOptions = { keepAlive: true };
const httpAgent = new http.Agent(agentOptions);
const httpsAgent = new https.Agent(agentOptions);
const httpAgent = userHttpAgent || userGlobalAgent || new http.Agent(agentOptions);
const httpsAgent = userHttpsAgent || userGlobalAgent || new https.Agent(agentOptions);

return {
send(request: Request): Readonly<Promise<Response>> {
Expand All @@ -27,7 +38,7 @@ export function createNodeHttpRequester(): Requester & Destroyable {
};

const req = (url.protocol === 'https:' ? https : http).request(options, response => {
// eslint-disable-next-line functional/no-let, functional/prefer-readonly-type
// eslint-disable-next-line functional/no-let
let contentBuffers: Buffer[] = [];

response.on('data', chunk => {
Expand Down