Skip to content

Commit fbe8a23

Browse files
aykutersoymillotp
andauthored
fix(php): native return types for AbstractModel methods (#3563)
Co-authored-by: Pierre Millot <[email protected]>
1 parent 6509e9b commit fbe8a23

File tree

3 files changed

+5
-3
lines changed

3 files changed

+5
-3
lines changed

clients/algoliasearch-client-php/lib/Model/AbstractModel.php

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@ abstract class AbstractModel
1616
*
1717
* @return string
1818
*/
19-
public function __toString()
19+
public function __toString(): string
2020
{
2121
return json_encode(
2222
ObjectSerializer::sanitizeForSerialization($this),
@@ -32,7 +32,7 @@ public function __toString()
3232
* @return mixed returns data which can be serialized by json_encode(), which is a value
3333
* of any type other than a resource
3434
*/
35-
public function jsonSerialize()
35+
public function jsonSerialize(): mixed
3636
{
3737
return ObjectSerializer::sanitizeForSerialization($this);
3838
}
@@ -42,7 +42,7 @@ public function jsonSerialize()
4242
*
4343
* @return string
4444
*/
45-
public function toHeaderValue()
45+
public function toHeaderValue(): string
4646
{
4747
return json_encode(ObjectSerializer::sanitizeForSerialization($this));
4848
}

config/generation.config.mjs

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -94,6 +94,7 @@ export const patterns = [
9494
'!clients/algoliasearch-client-php/**',
9595
'clients/algoliasearch-client-php/lib/Api/*',
9696
'clients/algoliasearch-client-php/lib/Model/**',
97+
'!clients/algoliasearch-client-php/lib/Model/AbstractModel.php',
9798
'clients/algoliasearch-client-php/lib/Configuration/*',
9899
'clients/algoliasearch-client-php/lib/ApiException.php',
99100
'clients/algoliasearch-client-php/lib/ObjectSerializer.php',

generators/src/main/java/com/algolia/codegen/AlgoliaPhpGenerator.java

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -43,6 +43,7 @@ public void processOpts() {
4343
supportingFiles.removeIf(file -> file.getTemplateFile().equals(".php-cs-fixer.php"));
4444
supportingFiles.removeIf(file -> file.getTemplateFile().equals(".php-cs-fixer.dist.php"));
4545
supportingFiles.removeIf(file -> file.getTemplateFile().equals("phpunit.xml.mustache"));
46+
supportingFiles.removeIf(file -> file.getTemplateFile().equals("AbstractModel.php"));
4647

4748
supportingFiles.add(new SupportingFile("Configuration.mustache", "lib/Configuration", "Configuration.php"));
4849
supportingFiles.add(new SupportingFile("ConfigWithRegion.mustache", "lib/Configuration", "ConfigWithRegion.php"));

0 commit comments

Comments
 (0)