Skip to content

fix(php): native return types for AbstractModel methods #3563

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

aykutersoy
Copy link
Contributor

🧭 What and Why

Follow up #3562

🎟 JIRA Ticket: -

Changes included:

  • List changes

🧪 Test

@aykutersoy aykutersoy requested a review from a team as a code owner August 20, 2024 14:04
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, just waiting for other PR to merge !

@millotp millotp merged commit fbe8a23 into algolia:main Aug 20, 2024
3 checks passed
algolia-bot added a commit that referenced this pull request Aug 20, 2024
…rated) [skip ci]

Co-authored-by: Aykut Ersoy <[email protected]>
Co-authored-by: Pierre Millot <[email protected]>
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Aug 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants