-
Notifications
You must be signed in to change notification settings - Fork 21
fix(php): Deprecation warning fix for PHP 8.1+ #3562
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(php): Deprecation warning fix for PHP 8.1+ #3562
Conversation
for `offsetExists`, `offsetGet`, `offsetSet`, `offsetUnset` methods
Hey @aykutersoy thanks for trying out the client and providing a fix :) I've reverted some changes because they are generated files, changing the mustache one is enough |
Hey @shortcuts, thanks for looking into this super fast 🙌 also adding a new commit 😆 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, thanks for the contribution!
Dang it! @shortcuts There's one more method needs native return type |
…kip ci] Co-authored-by: Aykut Ersoy <[email protected]> Co-authored-by: shortcuts <[email protected]>
if you need it asap it would be best for you to directly contribute, otherwise we can log it on our side and tackle that later |
algolia/api-clients-automation#3562 Co-authored-by: algolia-bot <[email protected]> Co-authored-by: Aykut Ersoy <[email protected]> Co-authored-by: shortcuts <[email protected]>
Done! Thank you 🙌 |
Native return types added for
offsetExists
,offsetGet
,offsetSet
,offsetUnset
methods🧭 What and Why
See: #3561
I had two option to get rid of deprecation messages, either add native types or add this
#[\ReturnTypeWillChange]
attribute. I opted in for native types.🎟 JIRA Ticket: -
Changes included:
offsetExists
,offsetGet
,offsetSet
,offsetUnset
methods🧪 Test