Skip to content

fix(php): Deprecation warning fix for PHP 8.1+ #3562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 20, 2024
Merged

fix(php): Deprecation warning fix for PHP 8.1+ #3562

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
4d2079f
fix(php): native return types added
aykutersoy Aug 20, 2024
7c41194
Merge remote-tracking branch 'origin/main' into fix/php-8.1-deprecati…
shortcuts Aug 20, 2024
c3677a2
chore: revert generated file updates
shortcuts Aug 20, 2024
3987cc6
Merge branch 'main' into fix/php-8.1-deprecation-fixes
shortcuts Aug 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions templates/php/model_generic.mustache
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,7 +346,7 @@ class {{classname}} extends \Algolia\AlgoliaSearch\Model\AbstractModel {{^parent
*
* @return boolean
*/
public function offsetExists($offset)
public function offsetExists($offset): bool
{
return isset($this->container[$offset]);
}
Expand All @@ -358,7 +358,7 @@ class {{classname}} extends \Algolia\AlgoliaSearch\Model\AbstractModel {{^parent
*
* @return mixed|null
*/
public function offsetGet($offset)
public function offsetGet($offset): mixed
{
return $this->container[$offset] ?? null;
}
Expand All @@ -371,7 +371,7 @@ class {{classname}} extends \Algolia\AlgoliaSearch\Model\AbstractModel {{^parent
*
* @return void
*/
public function offsetSet($offset, $value)
public function offsetSet($offset, $value): void
{
if (is_null($offset)) {
$this->container[] = $value;
Expand All @@ -387,7 +387,7 @@ class {{classname}} extends \Algolia\AlgoliaSearch\Model\AbstractModel {{^parent
*
* @return void
*/
public function offsetUnset($offset)
public function offsetUnset($offset): void
{
unset($this->container[$offset]);
}
Expand Down
Loading