Skip to content

chore(scripts): always install node modules during release process #1012

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 12, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Sep 12, 2022

🧭 What and Why

The node_modules inside clients/algoliasearch-client-javascript are required to release, but we never install them locally in reality.

@millotp millotp self-assigned this Sep 12, 2022
@millotp millotp requested a review from a team as a code owner September 12, 2022 14:33
@millotp millotp requested review from damcou and shortcuts September 12, 2022 14:33
@netlify
Copy link

netlify bot commented Sep 12, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit 1129e40
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/631f43320b853800084be8ab

@algolia-bot
Copy link
Collaborator

algolia-bot commented Sep 12, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp merged commit f03f671 into main Sep 12, 2022
@millotp millotp deleted the chore/always-install-yarn branch September 12, 2022 15:55
algolia-bot added a commit to algolia/algoliasearch-client-php that referenced this pull request Sep 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants