Skip to content

feat(specs): add modelID as part of getModelMetrics response #1075

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 12, 2022

Conversation

writeens
Copy link
Contributor

@writeens writeens commented Oct 11, 2022

🧭 What and Why

add modelID as part of getModelMetrics response
Please find spec here

Changes included:

  • Changing the structure of the getModelMetrics response (within Predict client) from
object[]

to

{modelID:string, metrics:object[]}

🧪 Test

CTS tests remain unchanged

@writeens writeens requested a review from a team as a code owner October 11, 2022 16:00
@writeens writeens requested review from damcou and millotp October 11, 2022 16:00
@netlify
Copy link

netlify bot commented Oct 11, 2022

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 4b34ab5
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63459330a1a0b60009a1510d
😎 Deploy Preview https://deploy-preview-1075--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@writeens writeens requested a review from bengreenbank October 11, 2022 16:01
@algolia-bot
Copy link
Collaborator

algolia-bot commented Oct 11, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@writeens writeens requested review from francoischalifour and removed request for bengreenbank October 12, 2022 08:58
Copy link
Member

@francoischalifour francoischalifour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@millotp millotp merged commit e84584d into main Oct 12, 2022
@millotp millotp deleted the feat/update-metrics-response branch October 12, 2022 09:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants