Skip to content

fix(clients): replace sources client with ingestion #1178

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 15, 2022

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Dec 14, 2022

🧭 What and Why

Remove sources client and replace it with it's big brother ingestion.

@millotp millotp self-assigned this Dec 14, 2022
@millotp millotp requested a review from a team as a code owner December 14, 2022 17:16
@millotp millotp requested review from damcou and shortcuts December 14, 2022 17:16
@netlify
Copy link

netlify bot commented Dec 14, 2022

Deploy Preview for api-clients-automation canceled.

Name Link
🔨 Latest commit ef9bae9
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/639a0eecc65f380009f4f8b4

@algolia-bot
Copy link
Collaborator

algolia-bot commented Dec 14, 2022

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp changed the title fix(ingestion): replace sources client with ingestion fix(clients): replace sources client with ingestion Dec 14, 2022
@millotp
Copy link
Collaborator Author

millotp commented Dec 14, 2022

@shortcuts should I force push the deleted files ?

@shortcuts
Copy link
Member

@shortcuts should I force push the deleted files ?

🤔 weird that the artefact restores them, feel free to if needed!

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@millotp millotp merged commit 1955288 into main Dec 15, 2022
@millotp millotp deleted the fix/replace-sources-ingestion branch December 15, 2022 08:58
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Dec 15, 2022
medicindev pushed a commit to medicindev/Algolia-Client--JavaScript that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants