-
Notifications
You must be signed in to change notification settings - Fork 21
feat(javascript): add error to APIError if possible #1234
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks great, just a small comment
clients/algoliasearch-client-javascript/packages/client-common/src/transporter/errors.ts
Show resolved
Hide resolved
clients/algoliasearch-client-javascript/packages/client-common/src/transporter/errors.ts
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
last one :D
clients/algoliasearch-client-javascript/packages/client-common/src/transporter/errors.ts
Show resolved
Hide resolved
clients/algoliasearch-client-javascript/packages/client-common/src/transporter/errors.ts
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lovely! thanks :D
algolia/api-clients-automation#1234 Co-authored-by: Pierre Millot <[email protected]>
algolia/api-clients-automation#1234 Co-authored-by: Pierre Millot <[email protected]>
🧭 What and Why
Create new error type
DetailedApiError
that will be used if anerror
is present in the response, mostly used by the ingestion API.