Skip to content

feat(javascript): add error to APIError if possible #1234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 17, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Jan 13, 2023

🧭 What and Why

Create new error type DetailedApiError that will be used if an error is present in the response, mostly used by the ingestion API.

@millotp millotp requested a review from a team as a code owner January 13, 2023 17:17
@millotp millotp self-assigned this Jan 13, 2023
@millotp millotp requested review from damcou and shortcuts January 13, 2023 17:17
@netlify
Copy link

netlify bot commented Jan 13, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit fa2dbbb
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63c66c98060599000879e84d
😎 Deploy Preview https://deploy-preview-1234--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 13, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp requested review from morganleroi and Fluf22 January 13, 2023 17:41
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, just a small comment

@millotp millotp requested a review from shortcuts January 17, 2023 09:27
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

last one :D

@millotp millotp requested a review from shortcuts January 17, 2023 09:41
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lovely! thanks :D

@millotp millotp enabled auto-merge (squash) January 17, 2023 09:44
@millotp millotp merged commit 010eed7 into main Jan 17, 2023
@millotp millotp deleted the feat/ingestion-errors branch January 17, 2023 09:45
algolia-bot added a commit to algolia/algoliasearch-client-javascript that referenced this pull request Jan 17, 2023
medicindev pushed a commit to medicindev/Algolia-Client--JavaScript that referenced this pull request Mar 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants