Skip to content

feat(specs): add sourceID query param to task list endpoint #1250

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 26, 2023

Conversation

Fluf22
Copy link
Contributor

@Fluf22 Fluf22 commented Jan 20, 2023

🧭 What and Why

🎟 JIRA Ticket: -

Changes included:

  • Add sourceID query param to help task filtering
  • Remove AuthenticationNone type
  • Add PlatformNone type

@Fluf22 Fluf22 requested a review from a team as a code owner January 20, 2023 11:36
@Fluf22 Fluf22 self-assigned this Jan 20, 2023
@Fluf22 Fluf22 requested review from damcou and shortcuts January 20, 2023 11:36
@netlify
Copy link

netlify bot commented Jan 20, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 5440705
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63d24e5e6408c1000997968a
😎 Deploy Preview https://deploy-preview-1250--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 20, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@Fluf22 Fluf22 requested review from millotp and removed request for shortcuts January 24, 2023 08:15
@Fluf22 Fluf22 force-pushed the feat/task-filter-sourceID branch from 7b4f2f1 to 6e70670 Compare January 24, 2023 15:02
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice ! but this doesn't reflect our api 🤔

@Fluf22 Fluf22 requested a review from millotp January 24, 2023 16:22
@Fluf22 Fluf22 force-pushed the feat/task-filter-sourceID branch from 6e70670 to 3fad787 Compare January 25, 2023 17:57
@Fluf22
Copy link
Contributor Author

Fluf22 commented Jan 25, 2023

@millotp and Netlify fixed itself 🙌🏻

Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! small question for auth

@Fluf22 Fluf22 force-pushed the feat/task-filter-sourceID branch from 3fad787 to 9f22785 Compare January 26, 2023 09:44
@Fluf22 Fluf22 requested a review from millotp January 26, 2023 09:54
millotp
millotp previously approved these changes Jan 26, 2023
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good ! non-blocking comment

@millotp millotp merged commit a60e679 into main Jan 26, 2023
@millotp millotp deleted the feat/task-filter-sourceID branch January 26, 2023 10:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants