Skip to content

fix(php): fix deserialization of models #1265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2023
Merged

Conversation

damcou
Copy link
Contributor

@damcou damcou commented Jan 26, 2023

🧭 What and Why

🎟 JIRA Ticket: DI-756

Changes included:

Now deserialization can be done this way:

$result = $client->search(...);
$object = ObjectSerializer::deserialize(json_encode($result), Algolia\AlgoliaSearch\Model\Search\SearchResponses::class);

@damcou damcou requested a review from a team as a code owner January 26, 2023 15:20
@damcou damcou self-assigned this Jan 26, 2023
@damcou damcou requested review from millotp and shortcuts January 26, 2023 15:20
@netlify
Copy link

netlify bot commented Jan 26, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 2a68796
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63d2a370b383f10008d1da09
😎 Deploy Preview https://deploy-preview-1265--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Jan 26, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

millotp
millotp previously approved these changes Jan 26, 2023
Copy link
Collaborator

@millotp millotp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good ! (I don't understand anything but I trust you 😛 )

@damcou
Copy link
Contributor Author

damcou commented Jan 26, 2023

Actually there was a small typo, sorry for that :p

@damcou damcou enabled auto-merge (squash) January 26, 2023 16:06
@damcou damcou merged commit 736bc4a into main Jan 27, 2023
@damcou damcou deleted the fix/DI-756/php-models-generation branch January 27, 2023 12:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PHP] Turn response into objects
3 participants