-
Notifications
You must be signed in to change notification settings - Fork 21
chore(java): add api compat check #1335
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
796c573
feat(java): add api compat check
aallam 7225c9b
add api check in the ci
aallam 83d3640
Merge branch 'main' into feat/java-api
aallam 44e7427
bump cache version
aallam eb612b7
ignore binary java output folders
aallam e45da15
update .gitignore
aallam 3b3369a
add a comment explaining what the package does
aallam 9151853
Merge branch 'main' into feat/java-api
aallam File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1 +1 @@ | ||
0.0.17 | ||
0.0.18 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -30,3 +30,4 @@ dist | |
|
||
generators/bin | ||
|
||
**/java/bin/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,39 @@ | ||
// This package is to check the public API (binary) compatibility of the latest | ||
// published release with `algoliasearch-client-java` package. | ||
|
||
import me.champeau.gradle.japicmp.JapicmpTask | ||
|
||
plugins { | ||
aallam marked this conversation as resolved.
Show resolved
Hide resolved
|
||
id 'java-library' | ||
id 'me.champeau.gradle.japicmp' version '0.4.1' | ||
} | ||
|
||
repositories { | ||
maven { url = "https://oss.sonatype.org/content/repositories/snapshots/" } | ||
mavenCentral() | ||
} | ||
|
||
def baselineConfig = configurations.register('baseline') | ||
def latestConfig = configurations.register('latest') | ||
|
||
dependencies { | ||
baseline('com.algolia:algoliasearch-client-java:4.+') { | ||
transitive = false | ||
} | ||
latest(projects.algoliasearchCore) | ||
} | ||
|
||
def japicmp = tasks.register('japicmp', JapicmpTask) { | ||
dependsOn tasks.findByName("jar") | ||
oldClasspath.setFrom(baselineConfig) | ||
newClasspath.setFrom(latestConfig) | ||
onlyBinaryIncompatibleModified.set(true) | ||
failOnModification.set(true) | ||
txtOutputFile.set(file("$buildDir/reports/japi.txt")) | ||
ignoreMissingClasses.set(true) | ||
includeSynthetic.set(true) | ||
} | ||
|
||
tasks.findByName('check').configure { | ||
dependsOn japicmp | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,3 +1,6 @@ | ||
rootProject.name = "algoliasearch-client-java" | ||
|
||
include(":algoliasearch-core") | ||
include(":api") | ||
|
||
enableFeaturePreview("TYPESAFE_PROJECT_ACCESSORS") |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.