Skip to content

feat(clients): upgrade to node 18 #1344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 16 commits into from
Feb 28, 2023
Merged

feat(clients): upgrade to node 18 #1344

merged 16 commits into from
Feb 28, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Feb 27, 2023

🧭 What and Why

Upgrade everything to node 18 because it's the active version.
Also upgraded yarn to the latest version, and many small dev packages to the latest version as well.

@millotp millotp self-assigned this Feb 27, 2023
@millotp millotp requested a review from a team as a code owner February 27, 2023 14:56
@netlify
Copy link

netlify bot commented Feb 27, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 4c01042
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63fe09e2365ed6000855ef27
😎 Deploy Preview https://deploy-preview-1344--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 27, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great job!

Fluf22
Fluf22 previously approved these changes Feb 27, 2023
Copy link
Contributor

@Fluf22 Fluf22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good as is 🤷🏻‍♂️
I guess we can only rely on your local testing for specific potential issues 😁

shortcuts
shortcuts previously approved these changes Feb 28, 2023
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks great, gg for tackling this

@@ -2,11 +2,11 @@
"files": [
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

after the revert, did the size still increased?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes it's the same, it must be because of all the small package increase or something else

@millotp millotp merged commit 2a4fe7e into main Feb 28, 2023
@millotp millotp deleted the feat/node-18 branch February 28, 2023 14:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants