Skip to content

chore(scripts): update gradle to v8 #1346

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 1, 2023
Merged

chore(scripts): update gradle to v8 #1346

merged 2 commits into from
Mar 1, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Feb 28, 2023

🧭 What and Why

gradle 8 is required by some of our dependencies, like #1342.

@millotp millotp requested a review from a team as a code owner February 28, 2023 11:12
@millotp millotp self-assigned this Feb 28, 2023
@millotp millotp requested review from aallam and shortcuts February 28, 2023 11:12
@netlify
Copy link

netlify bot commented Feb 28, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit 3ef66b8
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63ff37941dc1c000088038a4
😎 Deploy Preview https://deploy-preview-1346--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Feb 28, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

shortcuts
shortcuts previously approved these changes Feb 28, 2023
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

does it have an impact on the generated client?

@millotp
Copy link
Collaborator Author

millotp commented Feb 28, 2023

shouldn't have, it's just tooling and we don't use many custom gradle plugin yet (wait until @aallam changes everything ahah)

@millotp millotp enabled auto-merge (squash) February 28, 2023 13:54
@millotp millotp disabled auto-merge February 28, 2023 13:59
aallam
aallam previously approved these changes Feb 28, 2023
Copy link
Member

@aallam aallam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! :D this should also improve build speed and .kts support! :D

@millotp millotp dismissed stale reviews from aallam and shortcuts via 3ef66b8 March 1, 2023 11:31
@millotp
Copy link
Collaborator Author

millotp commented Mar 1, 2023

rebasing to get the debian image, and now it works locally and on the CI :)

@millotp millotp requested a review from shortcuts March 1, 2023 11:35
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GG

@millotp millotp merged commit a32ba53 into main Mar 1, 2023
@millotp millotp deleted the chore/gradle-8 branch March 1, 2023 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants