Skip to content

chore(all): upgrade openapi-generator to v6.4.0 #1360

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 2, 2023

Conversation

millotp
Copy link
Collaborator

@millotp millotp commented Mar 1, 2023

🧭 What and Why

🎟 JIRA Ticket: DI-904

Upgrade to the latest version, it was a lot less difficult than last time, I guess some bugs got fixed along the way.
It changes some weird things on the generated clients, but all the tests are okay, maybe it was because of inlining ?

Changes included:

  • Build specs locally before generating CTS, the same as for generate clients.

@millotp millotp requested a review from a team as a code owner March 1, 2023 18:47
@millotp millotp self-assigned this Mar 1, 2023
@millotp millotp requested review from damcou and mehmetaligok March 1, 2023 18:47
@netlify
Copy link

netlify bot commented Mar 1, 2023

Deploy Preview for api-clients-automation ready!

Name Link
🔨 Latest commit fa92c08
🔍 Latest deploy log https://app.netlify.com/sites/api-clients-automation/deploys/63ff9db627834b000894250f
😎 Deploy Preview https://deploy-preview-1360--api-clients-automation.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@algolia-bot
Copy link
Collaborator

algolia-bot commented Mar 1, 2023

✗ The generated branch has been deleted.

If the PR has been merged, you can check the generated code on the main branch.
You can still access the code generated on main via this commit.

@millotp millotp requested a review from shortcuts March 1, 2023 18:48
Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

~ o ~ smooooooth

@@ -4,6 +4,9 @@
{{#tsImports}}
import { {{classname}} } from '{{filename}}';
{{/tsImports}}
{{#interfaces.size}}{{#composedSchemas.allOf}}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

l o v e l y

Copy link
Member

@shortcuts shortcuts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

meant to approve

@millotp millotp merged commit 5b7ed99 into main Mar 2, 2023
@millotp millotp deleted the chore/upgrade-openapi-generator branch March 2, 2023 08:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants