chore(scripts): use spinnies for multi spinner #1365
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for api-clients-automation ready!
To edit notification comments on pull requests, go to your Netlify site settings. |
✗ The generated branch has been deleted.If the PR has been merged, you can check the generated code on the |
shortcuts
reviewed
Mar 2, 2023
| @@ -1,24 +1,21 @@ | |||
| /* eslint-disable no-case-declarations */ | |||
There was a problem hiding this comment.
I'm thinking that we should always go verbose mode now that we are "out" of the hard testing phase, wdyt?
There was a problem hiding this comment.
you mean on the CI ?
There was a problem hiding this comment.
nope everywhere, I feel like people doesn't know it can be verbose and actually most of the time you want to see what's going on
This was referenced Mar 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🧭 What and Why
Finally fix the long lasting bug of
orahandling 1 spinner only, using spinnies although a bit outdated, it works very well !Changes included:
verboseglobalskipUtilsoption🧪 Test
yarn docker build specs -s